GUACAMOLE-1746: docker enable usage of custom certificate#419
Open
ronansalmon wants to merge 2 commits intoapache:mainfrom
Open
GUACAMOLE-1746: docker enable usage of custom certificate#419ronansalmon wants to merge 2 commits intoapache:mainfrom
ronansalmon wants to merge 2 commits intoapache:mainfrom
Conversation
necouchman
requested changes
Apr 8, 2023
Contributor
necouchman
left a comment
necouchman
left a comment
There was a problem hiding this comment.
Overall I think this is fine - just one thing that I think should be changed.
@mike-jumper Any concerns with the direction of this change? It adds a start.sh script similar to the guacamole-client Docker image, but seems like Ronan has tried to maintain the same sort of script on this side, so looks okay to me.
Contributor
|
@ronansalmon This now how some conflicts that need to be resolved. @mike-jumper Any feedback on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker: Added a start.sh script that parse env variables
Added documentation for standalone and docker version on how to create and use a custom certificate.